Refactor: RenameRequest entry (copilot fixes)#923
Merged
rimu-stack merged 10 commits intodevfrom Feb 3, 2026
Merged
Conversation
milov-dmitriy
requested review from
rimu-stack
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull request overview
This PR applies minor refactoring fixes suggested by Copilot to the ModifyRequest class in the LDAP protocol implementation. The changes include code quality improvements, better naming conventions, and optimizations.
Changes:
- Refactored
_old_valstoold_valswith proper Pydantic Field definition - Updated attribute name comparisons to use
change.l_typefor consistency - Fixed parameter naming from
messagetoerror_messagein error responses - Added error handling for
KRBAPIRenamePrincipalError - Optimized
base_dirto be lazily loaded only when needed
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Misha-Shvets
approved these changes
Feb 3, 2026
rimu-stack
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Небольшие правки замечаний от копилоты